✨(auth) Add slient login #1690
✨(auth) Add slient login #1690
Conversation
arnaud-robin
force-pushed
the
silent-login
branch
from
fc97595 to
2d5d759
Compare
Currently users already logged in to the SSO have to click on the login button again to be connected. This extra step should not be necessary. This commit uses the "silent=true" parameter to the login endpoint to avoid the extra step.
arnaud-robin
force-pushed
the
silent-login
branch
from
2d5d759 to
9b6703f
Compare
|
This implementation is heavily copied from @lebaudantoine work. |
|
Size Change: +1.61 kB (+0.04%) Total Size: 4.12 MB
|
arnaud-robin
added
the
FAST
|
@AntoLC fyi |
AntoLC
left a comment
AntoLC
left a comment
There was a problem hiding this comment.
We need a test to assert that it is working, the tests don't seem happy btw.
If I understand correctly, even if our cookies is dead (frontend side), if the SSO recognize the user it will not prompt the user again, isn't it ?
|
Yes, I’ll update the tests accordingly. I also plan to make this option configurable so that self-hosted instances using identity providers that don’t support this parameter don’t end up with a broken login flow. But you're right, the goal is that even if the user has never logged into Docs before, or if the Docs session has expired, we still try to reuse an existing IdP session so the user doesn’t have to click the login button. |
Problem
Right now users already logged in to the SSO have to click on the login button again to be connected. This extra step should not be necessary and some partners have complained
Proposed solution
This PR uses the "silent=true" parameter in the lasuite login endpoint to avoid showing the IdP login screen if user already have an active session.